This repository has been archived by the owner on May 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
[REVIEW] Tokenizer with rmm integration #155
Merged
brhodes10
merged 71 commits into
rapidsai:branch-0.15
from
brhodes10:feature/tokenizer-rmm
Jun 12, 2020
Merged
[REVIEW] Tokenizer with rmm integration #155
brhodes10
merged 71 commits into
rapidsai:branch-0.15
from
brhodes10:feature/tokenizer-rmm
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brhodes10
commented
May 15, 2020
•
edited
Loading
edited
- Updated tokenizer to use rmm
- Added tokenizer benchmark and unit tests
update to use thrust exclusive scan Co-authored-by: Mark Harris <mharris@nvidia.com>
update to use thrust exclusive scan Co-authored-by: Mark Harris <mharris@nvidia.com>
…cu " This reverts commit 2f99323.
Hi @harrism I have made changes based on your comments. I saw areas where I could apply your suggestions to the |
harrism
reviewed
Jun 10, 2020
I believe there are a few vectors in those files that we use as input to the basic tokenizer. They are large, and that's what is likely causing the large diffs. |
rerun tests |
2 similar comments
rerun tests |
rerun tests |
Co-authored-by: Mark Harris <mharris@nvidia.com>
harrism
approved these changes
Jun 11, 2020
rerun tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.